Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'rc' as an ignore filter #464

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Added 'rc' as an ignore filter #464

merged 2 commits into from
Aug 30, 2023

Conversation

StandingPadAnimations
Copy link
Collaborator

MCprep is moving towards a new 5-stage development cycle (Stage 0 to 4), where Stage 4 involves creating release candidates for testing and feedback purposes. Release candiates use the format "#.#.#.#-rc-#" for tags, to make them distinct from regular releases.

Thus, the addon updater should ignore these release candidates, as stability is not guranteed.

MCprep is moving towards a new 5-stage development cycle (Stage 0 to 4),
where Stage 4 involves creating release candidates for testing and
feedback purposes. Release candiates use the format "#.#.#.#-rc-#" for
tags, to make them distinct from regular releases.

The addon updater should ignore these release candidates, as stability
is not guranteed.
@StandingPadAnimations StandingPadAnimations marked this pull request as ready for review August 20, 2023 20:18
Copy link
Member

@TheDuckCow TheDuckCow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, one comment. Thanks for making the PR, and helping establish a cadence for release candidates

MCprep_addon/addon_updater_ops.py Outdated Show resolved Hide resolved
Instead of checking for just rc, we also check for alpha and beta

Co-authored-by: Patrick W. Crawford <theduckcow@live.com>
@StandingPadAnimations StandingPadAnimations merged commit b26b5f9 into dev Aug 30, 2023
@StandingPadAnimations StandingPadAnimations deleted the rc-ignore branch August 30, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants